Messages in this thread | | | Date | Thu, 26 Sep 2013 10:21:47 +0200 | From | Pavel Machek <> | Subject | Re: [PATCH V4 13/15] Hibernate: introduced SNAPSHOT_SIG_HASH config for select hash algorithm |
| |
Hi!
> > On Sun 2013-09-15 08:56:59, Lee, Chun-Yi wrote: > > > This patch introduced SNAPSHOT_SIG_HASH config for user to select which > > > hash algorithm will be used during signature generation of snapshot. > > > > This series is big enough already... and who is going to test it? > > The hash config not just for testing, it's relate to the performance and > secure between different hash algorithms.
I'm not saying it is for testing. I'm saying that selection makes testing harder.
> There have person raised in LPC say he don't like SHA algorithm.
Well, I don't like the config option.
> > There's no need to make hash configurable. Just select one that works. > > SHA1 has good performance, and SHA512 has better security, which one you > like it?
Use SHA1. It is completely adequate for what you are trying to do.
Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
| |