lkml.org 
[lkml]   [2013]   [Sep]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/3] iio: ti_am335x_adc: fix static in function header
    On Sun, Sep 22, 2013 at 07:03:53PM +0100, Jonathan Cameron wrote:
    > On 09/22/13 09:20, Zubair Lutfullah wrote:
    > > Static is missing in function header. Corrected.
    > >
    > > Signed-off-by: Zubair Lutfullah <zubair.lutfullah@gmail.com>
    > Applied to the togreg branch of iio.git
    >
    > As you've probably gathered, a run of sparse on your code before posting is a
    > great way to pick up on little things like this. Also, coccinelle and
    > smatch if you want to do a thorough job - each gets a slightly different
    > set of common bugs. I tend to run some combination of those, but wasn't
    > set up to build this driver so didn't pick up on this.

    Thank-you. I'll look into it. Are these scripts within the scripts/ directory?
    Zubair

    >
    > Another one clocked up to the autobuilders. Note it is normal to give
    > a reported-by line to give them some credit. I've added one.

    Noted

    > Jonathan
    > > ---
    > > drivers/iio/adc/ti_am335x_adc.c | 2 +-
    > > 1 file changed, 1 insertion(+), 1 deletion(-)
    > >
    > > diff --git a/drivers/iio/adc/ti_am335x_adc.c b/drivers/iio/adc/ti_am335x_adc.c
    > > index 5287bff..91dce1f 100644
    > > --- a/drivers/iio/adc/ti_am335x_adc.c
    > > +++ b/drivers/iio/adc/ti_am335x_adc.c
    > > @@ -226,7 +226,7 @@ static const struct iio_buffer_setup_ops tiadc_buffer_setup_ops = {
    > > .postdisable = &tiadc_buffer_postdisable,
    > > };
    > >
    > > -int tiadc_iio_buffered_hardware_setup(struct iio_dev *indio_dev,
    > > +static int tiadc_iio_buffered_hardware_setup(struct iio_dev *indio_dev,
    > > irqreturn_t (*pollfunc_bh)(int irq, void *p),
    > > irqreturn_t (*pollfunc_th)(int irq, void *p),
    > > int irq,
    > >


    \
     
     \ /
      Last update: 2013-09-26 10:21    [W:3.689 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site