lkml.org 
[lkml]   [2013]   [Sep]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] arm32: kvm: rename CONFIG_KVM_ARM_MAX_VCPUS
On Tue, Sep 24, 2013 at 04:09:28PM +0200, Andrew Jones wrote:
> Drop the _ARM_ part of the name. We can then introduce a config option
> like this to aarch64 and other arches using the same name - allowing
> grep to show them all. Also update the help text to describe the option
> more completely.
>
> Signed-off-by: Andrew Jones <drjones@redhat.com>
>
> ---
> v2: reword help text some more
> ---
> arch/arm/include/asm/kvm_host.h | 4 ++--
> arch/arm/kvm/Kconfig | 9 +++++----
> 2 files changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm/include/asm/kvm_host.h b/arch/arm/include/asm/kvm_host.h
> index 7d22517d80711..c614d3eb176c6 100644
> --- a/arch/arm/include/asm/kvm_host.h
> +++ b/arch/arm/include/asm/kvm_host.h
> @@ -25,8 +25,8 @@
> #include <asm/fpstate.h>
> #include <kvm/arm_arch_timer.h>
>
> -#if defined(CONFIG_KVM_ARM_MAX_VCPUS)
> -#define KVM_MAX_VCPUS CONFIG_KVM_ARM_MAX_VCPUS
> +#if defined(CONFIG_KVM_MAX_VCPUS)
> +#define KVM_MAX_VCPUS CONFIG_KVM_MAX_VCPUS
> #else
> #define KVM_MAX_VCPUS 0
> #endif
> diff --git a/arch/arm/kvm/Kconfig b/arch/arm/kvm/Kconfig
> index ebf5015508b52..8e56ccf45edce 100644
> --- a/arch/arm/kvm/Kconfig
> +++ b/arch/arm/kvm/Kconfig
> @@ -40,16 +40,17 @@ config KVM_ARM_HOST
> ---help---
> Provides host support for ARM processors.
>
> -config KVM_ARM_MAX_VCPUS
> +config KVM_MAX_VCPUS
> int "Number maximum supported virtual CPUs per VM"
> depends on KVM_ARM_HOST
> default 4
> help
> Static number of max supported virtual CPUs per VM.
>
> - If you choose a high number, the vcpu structures will be quite
> - large, so only choose a reasonable number that you expect to
> - actually use.
> + The default is set to the highest number of vcpus that
> + current hardware supports. Choosing a lower number decreases
> + the size of the VM data structure. This number may also be
> + increased.
>
Maybe I'm being forgetful, but what do you mean by "This number may also
be increased" ?

-Christoffer


\
 
 \ /
  Last update: 2013-09-25 21:41    [W:0.111 / U:0.076 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site