Messages in this thread | | | From | Bartlomiej Zolnierkiewicz <> | Subject | Re: [RFC PATCH 09/15] ata: ti_sata: Add Texas Instruments SATA Wrapper driver | Date | Wed, 25 Sep 2013 14:49:56 +0200 |
| |
On Wednesday, September 25, 2013 02:37:19 PM Bartlomiej Zolnierkiewicz wrote:
[...]
> > +#ifdef CONFIG_PM > > + > > +static int ti_sata_resume(struct device *dev) > > +{ > > + pm_runtime_disable(dev); > > + pm_runtime_set_active(dev); > > + pm_runtime_enable(dev); > > This doesn't look like a correct ->resume method: > * it shouldn't touch runtime PM at all > * for each ->resume method there should be a corresponding ->suspend method > > Moreover this whole wrapper driver seems strange, why not just add a proper > runtime PM support to ahci_platform driver instead?
Hmm, even this shouldn't be needed as this wrapper driver doesn't have ->runtime_suspend and ->runtime resume methods.
What exactly is the purpose of the existence of this wrapper driver?
Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics
| |