Messages in this thread | | | Date | Tue, 24 Sep 2013 10:59:07 -0600 | From | Stephen Warren <> | Subject | Re: [PATCH v3] gpio: interrupt consistency check for OF GPIO IRQs |
| |
On 09/24/2013 02:31 AM, Linus Walleij wrote: > On Mon, Sep 23, 2013 at 10:21 PM, Stephen Warren <swarren@wwwdotorg.org> wrote: ... >> Perhaps rather than having the gpio_chip/irq_chip drivers physically >> implement a function which calls this common code, they could set some >> flags/data/... in the struct gpio_chip/irq_chip indicating that they >> desire the core code that implements the error-checking to be enabled. > > I think it should more be like a function they can call to flag > a GPIO as used for IRQ.
For the record, that's pretty much exactly what I meant by implementing it in the drivers. The irq_chip driver knows when the IRQ has been requested, and calls some gpiolib function to mark the GPIO as in-use-as-an-IRQ.
| |