Messages in this thread | | | Date | Mon, 23 Sep 2013 23:27:44 +0100 | From | Mark Brown <> | Subject | Re: [PATCH 5/5] mfd: arizona: Add device tree bindings for MICBIAS generators |
| |
On Mon, Sep 23, 2013 at 07:30:43PM +0100, Charles Keepax wrote:
> + - wlf,micbias1 : Configuration for the micbias regulator, should include 5 > + cells. > + The first cell is the output voltage in millivolts > + The second cell a non-zero value indicates an external capacitor is fitted > + The third cell a non-zero value indicates the micbias should be actively > + discharged > + The four cell a non-zero value indicates that the micbias should be > + brought up slowly to reduce pops
I would suggest defining a subnode with boolean properties for these, it's not massively legible to have this many random numbers. Consider using the regulator binding, microphone biases are after all regulators.
> + The fifth cell a non-zero value indicates the micbias should be bypassed > + and simply output MICVDD
This is something that should be being varied at runtime in detection scenarios, the meaning ought to be being tightened up here. [unhandled content-type:application/pgp-signature] | |