Messages in this thread | | | Date | Mon, 23 Sep 2013 16:04:50 +0200 | Subject | Re: checkpatch guide for newbies | From | Geert Uytterhoeven <> |
| |
On Mon, Sep 23, 2013 at 2:46 PM, Peter Senna Tschudin <peter.senna@gmail.com> wrote: >> Ask yourself, is the warning message is clear? Is it needed? Could a
s/is clear/clear/
>> It's preferred if the operator goes at the end of the first line instead of at >> the start of the second line: >> Bad: >> - PowerData = (1 << 31) | (0 << 30) | (24 << 24) >> - | BitReverse(w89rf242_txvga_data[i][0], 24); >> Good: >> + PowerData = (1 << 31) | (0 << 30) | (24 << 24) | >> + BitReverse(w89rf242_txvga_data[i][0], 24); > What is the rule for where to start the second line here?
Either aligned to the equivalent part on the previous line (i.e. "BitReverse" is aligned with "(1 << 31)"), or one indent step more than the beginning of the first line (i.e. "BitReverse" is indented by one more TAB tjan "PowerData").
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |