Messages in this thread Patch in this message | | | From | "Kirill A. Shutemov" <> | Subject | [PATCHv6 03/22] memcg, thp: charge huge cache pages | Date | Mon, 23 Sep 2013 15:05:31 +0300 |
| |
mem_cgroup_cache_charge() has check for PageCompound(). The check prevents charging huge cache pages.
I don't see a reason why the check is present. Looks like it's just legacy (introduced in 52d4b9a memcg: allocate all page_cgroup at boot).
Let's just drop it.
Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com> Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> Acked-by: Dave Hansen <dave.hansen@linux.intel.com> Acked-by: Michal Hocko <mhocko@suse.cz> --- mm/memcontrol.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/mm/memcontrol.c b/mm/memcontrol.c index d5ff3ce130..0b87a1bd25 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c @@ -3963,8 +3963,7 @@ int mem_cgroup_cache_charge(struct page *page, struct mm_struct *mm, if (mem_cgroup_disabled()) return 0; - if (PageCompound(page)) - return 0; + VM_BUG_ON(PageCompound(page) && !PageTransHuge(page)); if (!PageSwapCache(page)) ret = mem_cgroup_charge_common(page, mm, gfp_mask, type); -- 1.8.4.rc3
| |