lkml.org 
[lkml]   [2013]   [Sep]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH V2 01/10] perf tools: fix path unpopulated in machine__create_modules()
    Date
    In machine__create_modules() the 'path' char array
    was used in a call to symbol__restricted_filename()
    without always being populated.

    Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
    ---
    tools/perf/util/machine.c | 8 ++++----
    1 file changed, 4 insertions(+), 4 deletions(-)

    diff --git a/tools/perf/util/machine.c b/tools/perf/util/machine.c
    index 933d14f..ddf917b 100644
    --- a/tools/perf/util/machine.c
    +++ b/tools/perf/util/machine.c
    @@ -785,14 +785,14 @@ static int machine__create_modules(struct machine *machine)
    const char *modules;
    char path[PATH_MAX];

    - if (machine__is_default_guest(machine))
    + if (machine__is_default_guest(machine)) {
    modules = symbol_conf.default_guest_modules;
    - else {
    - sprintf(path, "%s/proc/modules", machine->root_dir);
    + } else {
    + snprintf(path, PATH_MAX, "%s/proc/modules", machine->root_dir);
    modules = path;
    }

    - if (symbol__restricted_filename(path, "/proc/modules"))
    + if (symbol__restricted_filename(modules, "/proc/modules"))
    return -1;

    file = fopen(modules, "r");
    --
    1.7.11.7


    \
     
     \ /
      Last update: 2013-09-22 12:41    [W:2.229 / U:0.072 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site