Messages in this thread | | | Date | Sun, 22 Sep 2013 16:02:37 -0700 | Subject | Re: [PATCH] block: Device driver for sTec's PCIe Kronos Card. | From | Olof Johansson <> |
| |
On Sat, Sep 21, 2013 at 1:01 PM, Jens Axboe <axboe@kernel.dk> wrote: > On Fri, Sep 20 2013, Andrew Morton wrote: >> On Tue, 17 Sep 2013 14:20:55 -0600 Jens Axboe <axboe@kernel.dk> wrote: >> >> > > So, it looks like this driver needs a bunch of work before it's ready >> > > to go in. Or, maybe it's better to submit it with a TODO list for the >> > > staging tree instead? >> > >> > Not disagreeing with you, it definitely needs a bit of cleaning. And so >> > far stec has not been very responsive in fixing those issues. >> >> Geeze. Here's what I came up with, mainly to make i386 compile: > > Thanks Andrew. It's not the fixes themselves that are tricky, I would > just have liked a little more proof that the submission wasn't just a > dump'n run.
Well, that's what much of the staging process is about, since it needs to come with a todo list (and that list needs to be taken care of before the driver graduates). Honestly, this looks like a prime candidate for that. But it's your tree and your call.
Thanks for applying the patch from Andrew, that resolves most of it for me right now.
-Olof
| |