Messages in this thread | | | Date | Sat, 21 Sep 2013 04:25:51 +0300 | Subject | Null pointer deference in drivers/power/pm2301_charger.c | From | Valentin Ilie <> |
| |
Hello,
I am trying to solve a NULL pointer deference in drivers/power/pm2301_charger.c (and to submit a trivial patch) but I am not sure how to do it.
Line 958 - 961 pm2 = (struct pm2xxx_charger*)i2c_get_clientdata(pm2xxx_i2c_client); if (!pm2) { dev_err(pm2->dev, "no pm2xxx_charger data supplied\n");
Line 976 - 978 pm2 = (struct pm2xxx_charger*)i2c_get_clientdata(pm2xxx_i2c_client); if (!pm2) { dev_err(pm2->dev, "no pm2xxx_charger data supplied\n");
As it can be clearly seen, pm2 is used with NULL value in dev_err. The question is, how to fix this? Should I delete the dev_err line or can I use printk (to avoid the need of a dev) ?
Thank you, Valentin
| |