Messages in this thread | | | Subject | Re: [PATCH 1/2] remove all uses of printf's %n | From | Tetsuo Handa <> | Date | Sat, 21 Sep 2013 09:28:14 +0900 |
| |
Kees Cook wrote: > >> - seq_printf(seq, "%*s\n", 127 - len, ""); > >> + seq_pad(seq, '\n'); > > > > Hmm, seq_pad is unintuitive. I would say it pads the string by '\n'. Of > > course it does not, but... > > I don't think this is a very serious problem. Currently, the padding > character is always ' ' for all existing callers, so it only makes > sense to make the trailing character an argument.
If you want, we can rename seq_pad() to seq_pad_and_putc(). Also we can pass both the padding character (e.g. ' ') and the trailing character (e.g. '\n') like seq_pad_and_putc((' ' << 8) | '\n'), though I wonder someone wants to use '\0', '\t', '\n' etc. as the padding character...
| |