lkml.org 
[lkml]   [2013]   [Sep]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v2 5/6] ACPI / processor: remove unnecessary if (!pr) check
    Date
    acpi_processor_errata() is only called in acpi_processor_get_info(),
    and the argument 'pr' passed to acpi_processor_errata() will never be
    NULL, so the if (!pr) check is unnecessary and can be removed.

    Since the 'pr' argument is not used by acpi_processor_errata() any more,
    so change the argument into void too.

    Signed-off-by: Hanjun Guo <hanjun.guo@linaro.org>
    ---
    drivers/acpi/acpi_processor.c | 8 ++------
    1 file changed, 2 insertions(+), 6 deletions(-)

    diff --git a/drivers/acpi/acpi_processor.c b/drivers/acpi/acpi_processor.c
    index 5364d02..7ce0750 100644
    --- a/drivers/acpi/acpi_processor.c
    +++ b/drivers/acpi/acpi_processor.c
    @@ -140,15 +140,11 @@ static int acpi_processor_errata_piix4(struct pci_dev *dev)
    return 0;
    }

    -static int acpi_processor_errata(struct acpi_processor *pr)
    +static int acpi_processor_errata(void)
    {
    int result = 0;
    struct pci_dev *dev = NULL;

    -
    - if (!pr)
    - return -EINVAL;
    -
    /*
    * PIIX4
    */
    @@ -220,7 +216,7 @@ static int acpi_processor_get_info(struct acpi_device *device)
    acpi_status status = AE_OK;
    static int cpu0_initialized;

    - acpi_processor_errata(pr);
    + acpi_processor_errata();

    /*
    * Check to see if we have bus mastering arbitration control. This
    --
    1.7.9.5


    \
     
     \ /
      Last update: 2013-09-02 06:41    [W:4.138 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site