Messages in this thread | | | Subject | Re: [PATCH] checkpatch: Add warning about submitting patches using --file | From | Joe Perches <> | Date | Mon, 02 Sep 2013 14:51:03 -0700 |
| |
On Mon, 2013-09-02 at 23:37 +0300, Dan Carpenter wrote: > On Mon, Sep 02, 2013 at 12:40:47PM -0700, Joe Perches wrote: > > +WARNING: When using --file mode, do not send patches that just make > > +whitespace or formatting changes unless more significant changes are > > +also made for other reasons in another patch. > > + > > This is a run on sentence.
Suggest alternatives. I suppose "are also made" could be shortened.
> Also I don't agree with it. Clean up > patches are good on their own.
Try getting one past James "stasis" Bottomley.
> There are parts of the kernel which are > not just in staging where I refuse to look at because it is so bad.
Me too.
> The problem is that people send "clean up" patches which don't clean up > the code or which make the code worse than the original.
Maybe the only way to learn coding taste is to have patches rejected.
> All they care > about is pleasing checkpatch.pl instead of actually thinking about what > they are doing. The message should just say something like, "Take a > step back and think about if this actually improves things for human > readers."
Maybe. Suggest better text.
| |