lkml.org 
[lkml]   [2013]   [Sep]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 0/3] cleanup of gpio_pcf857x.c

Hi

Sorry for my many response.

> This patch series
> - removes the irq_demux_work
> - Uses devm_request_threaded_irq
> - Call the user handler iff gpio_to_irq is done.
>
> v1 --> v2
> Split v1 to 3 patches
> v2 --> v3
> Remove the unnecessary dts patches.
>
>
> George Cherian (3):
> gpio: pcf857x: change to devm_request_threaded_irq
> gpio: pcf857x: remove the irq_demux_work
> gpio: pcf857x: call the gpio user handler iff gpio_to_irq is done
>
> drivers/gpio/gpio-pcf857x.c | 51 +++++++++++++++++++++++----------------------
> 1 file changed, 26 insertions(+), 25 deletions(-)

Basically, I have no objection about these patches,
but I have 2 opinions
- I guess we can merge #1 and #2 patches ?
("as is" is very OK for me though)
- we don't need gpio->irq any more ?
(additional patch is very OK for me)

Best regards
---
Kuninori Morimoto


\
 
 \ /
  Last update: 2013-09-02 09:21    [W:1.401 / U:0.612 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site