Messages in this thread | | | Date | Wed, 18 Sep 2013 12:38:53 -0400 (EDT) | Subject | Re: [PATCH] net: tsi108: Prevent compiler warning | From | David Miller <> |
| |
From: Thierry Reding <thierry.reding@gmail.com> Date: Wed, 18 Sep 2013 14:49:55 +0200
> The dump_eth_one() function is only used if DEBUG is enabled, so protect > it by a corresponding #ifdef DEBUG block. > > Signed-off-by: Thierry Reding <treding@nvidia.com>
I would prefer that this function and the one call site is simply removed instead.
This kind of thing can be provided via ethtool register dumps and therefore without all of the ugliness this ad-hoc stuff presents.
| |