Messages in this thread | | | Date | Wed, 18 Sep 2013 10:19:20 -0500 | Subject | Re: [PATCH 05/11] cifs: fix filp leak in cifs_atomic_open() | From | Steve French <> |
| |
Do you want me to merge this via my tree (cifs-2.6.git) or another?
On Mon, Sep 16, 2013 at 7:51 AM, Miklos Szeredi <miklos@szeredi.hu> wrote: > From: Miklos Szeredi <mszeredi@suse.cz> > > If an error occurs after having called finish_open() then fput() needs to > be called on the already opened file. > > Signed-off-by: Miklos Szeredi <mszeredi@suse.cz> > Cc: Steve French <sfrench@samba.org> > Cc: stable@vger.kernel.org > --- > fs/cifs/dir.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/fs/cifs/dir.c b/fs/cifs/dir.c > index d3e2eaa..5384c2a 100644 > --- a/fs/cifs/dir.c > +++ b/fs/cifs/dir.c > @@ -500,6 +500,7 @@ cifs_atomic_open(struct inode *inode, struct dentry *direntry, > if (server->ops->close) > server->ops->close(xid, tcon, &fid); > cifs_del_pending_open(&open); > + fput(file); > rc = -ENOMEM; > } > > -- > 1.8.1.4 >
-- Thanks,
Steve
| |