Messages in this thread | | | Date | Wed, 18 Sep 2013 17:28:37 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH 0/2] vsprintf: ignore %n again |
| |
On Wed, Sep 18, 2013 at 05:11:04PM +0300, Dan Carpenter wrote: > asmlinkage __printf(1, 2) __cold > int printk(const char *fmt, ...); > +#define printk(fmt, ...) do { \ > + compiletime_assert(__builtin_constant_p(fmt), \ > + "Non-constant format string"); \ > + printk(fmt, ##__VA_ARGS__); \ > +} while (0)
Oops... That breaks the compile for printk.c.
Also don't we want 'const char fmt[] = "foo %s";' to be a valid format string?
regards, dan carpenter
| |