Messages in this thread | | | From | David Howells <> | Subject | Re: [PATCH 5/5] lib: Add error string support to printks | Date | Wed, 18 Sep 2013 12:04:55 +0100 |
| |
Joe Perches <joe@perches.com> wrote:
> On Tue, 2013-09-17 at 18:08 -0500, danielfsantos@att.net wrote: > > This adds an extension for the integral format specifier suffix of 'e', > > so that the format %[duxXo]e will result in printing an number (as > > before) in addition to a name and descrption for an error code, if such > > support is enabled and a name and descrption is found. > > > > My initial thought was to use the glibc extension of '%m', but this > > format specifier uses the value of libc's errno and adding a value > > breaks gcc's printf parsing. I'm not convinced that the 'e' extension > > is optimal, although there are only four instances of this pattern in > > the kernel that would need to be changed. > > > > git grep -E '".*%[#0\ +\-]*[0-9]*[hljzt]*[idoxXu]e' > > > > Alternatively, 'E' was another thought for a suffix as well. > > I'd much rather see another %p extension used instead > of generating odd output given normal printf formats. > > %pE might work
I guess you'd use that with ERR_PTR(). On one hand, it would look decidedly odd, but on the other hand, we have errors in pointers in a lot of places already which wouldn't then need converting back - so it doesn't seem entirely unreasonable.
David
| |