Messages in this thread | | | Date | Tue, 17 Sep 2013 16:44:25 -0700 | From | Tony Lindgren <> | Subject | Re: [PATCH] mailbox: remove unnecessary platform_set_drvdata() |
| |
* Suman Anna <s-anna@ti.com> [130823 09:50]: > + OMAP mailing list > > Tony, > Can you pick up this minor cleanup patch? > > regards > Suman > > On 08/21/2013 09:10 PM, Jingoo Han wrote: > > The driver core clears the driver data to NULL after device_release > > or on probe failure. Thus, it is not needed to manually clear the > > device driver data to NULL. > > > > Signed-off-by: Jingoo Han <jg1.han@samsung.com> > > Acked-by: Suman Anna <s-anna@ti.com>
OK applying into omap-for-v3.12/fixes thanks.
Regards,
Tony
> > --- > > drivers/mailbox/mailbox-omap2.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/drivers/mailbox/mailbox-omap2.c b/drivers/mailbox/mailbox-omap2.c > > index eba380d..42d2b89 100644 > > --- a/drivers/mailbox/mailbox-omap2.c > > +++ b/drivers/mailbox/mailbox-omap2.c > > @@ -325,7 +325,6 @@ static int omap2_mbox_remove(struct platform_device *pdev) > > kfree(privblk); > > kfree(mboxblk); > > kfree(list); > > - platform_set_drvdata(pdev, NULL); > > > > return 0; > > } > > >
| |