lkml.org 
[lkml]   [2013]   [Sep]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Fix style in s3c-hsotg.c
On Tue 2013-09-17 10:42:30, Felipe Balbi wrote:
> Hi,
>
> On Mon, Sep 02, 2013 at 03:58:32PM +0200, Pavel Machek wrote:
> > Hi!
> >
> > checkpatch.pl has some valid complaints about style in s3c-hsotg.c :
> > macro with if should be really enclosed in do {} while, and puts is
> > going to be slightly faster.
> >
> > Here's suggested patch. I don't have the hardware, so it is completely
> > untested.
> >
> > Signed-off-by: Pavel Machek, <pavel@denx.de>
>
> this is not how you send a patch, please read
> Documentation/SubmittingPatches

Have you considered possibility that this is how you nudge maintainer
into fix their coding style?

Thanks,
Pavel

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html


\
 
 \ /
  Last update: 2013-09-18 00:21    [W:0.075 / U:0.264 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site