Messages in this thread | | | Date | Wed, 18 Sep 2013 00:04:27 +0200 | From | Pavel Machek <> | Subject | Re: Fix style in s3c-hsotg.c |
| |
On Tue 2013-09-17 10:42:30, Felipe Balbi wrote: > Hi, > > On Mon, Sep 02, 2013 at 03:58:32PM +0200, Pavel Machek wrote: > > Hi! > > > > checkpatch.pl has some valid complaints about style in s3c-hsotg.c : > > macro with if should be really enclosed in do {} while, and puts is > > going to be slightly faster. > > > > Here's suggested patch. I don't have the hardware, so it is completely > > untested. > > > > Signed-off-by: Pavel Machek, <pavel@denx.de> > > this is not how you send a patch, please read > Documentation/SubmittingPatches
Have you considered possibility that this is how you nudge maintainer into fix their coding style?
Thanks, Pavel
-- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
| |