lkml.org 
[lkml]   [2013]   [Sep]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] block: Device driver for sTec's PCIe Kronos Card.
From
On Thu, Sep 5, 2013 at 7:12 AM, Jens Axboe <axboe@kernel.dk> wrote:
> On 09/05/2013 06:00 AM, Jeff Moyer wrote:
>> OS Engineering <osengineering@stec-inc.com> writes:
>>
>>> Hi Jeff,
>>>
>>> Thank you for reviewing the patch.
>>
>> No problem. Jens, any objection to queueing this up for 3.12?
>
> I'll give it a look-over, but usually I'm pretty lax when it comes to
> new drivers. So no, I'd be surprised if we can't queue this up for 3.12.

I came across this driver because it was spewing a lot of really
trivial and easy to fix compiler warnings. Silly stuff such as
printing u32 with %lu.

From a quick look at the code, several things are immediately apparent:

First, checkpatch says, on the currently existing file in -next:

total: 3 errors, 61 warnings, 5817 lines checked

Code like this looks _really_ confused:

barrier();
val = readl(skdev->mem_map[1] + offset);
barrier();

There are also some crazy long functions that should be refactored,
such as skd_request_fn().

So, it looks like this driver needs a bunch of work before it's ready
to go in. Or, maybe it's better to submit it with a TODO list for the
staging tree instead?


-Olof


\
 
 \ /
  Last update: 2013-09-17 21:21    [W:0.164 / U:0.380 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site