lkml.org 
[lkml]   [2013]   [Sep]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 21/24] Staging: winbond: wb35tx: Replace printk with netdev_err
From
Date
On Mon, 2013-09-16 at 15:43 +0200, Iker Pedrosa wrote:
> The previously used printk lacked the warning level, now we've got a more accurate way to know the error.
[]
> diff --git a/drivers/staging/winbond/wb35tx.c b/drivers/staging/winbond/wb35tx.c
[]
> @@ -32,7 +32,7 @@ static void Wb35Tx_complete(struct urb *pUrb)
> struct wb35_tx *pWb35Tx = &pHwData->Wb35Tx;
> struct wb35_mds *pMds = &adapter->Mds;
>
> - printk("wb35: tx complete\n");
> + netdev_err(pUrb->dev, "wb35: tx complete\n");

This one should either be removed or changed to netdev_dbg
with the "wb35: " prefix removed.



\
 
 \ /
  Last update: 2013-09-17 19:01    [W:0.198 / U:0.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site