Messages in this thread | | | Date | Tue, 17 Sep 2013 21:48:08 +0530 | Subject | Re: [PATCH 5/5] cpufreq: use correct values of cpus in __cpufreq_remove_dev_finish() | From | Viresh Kumar <> |
| |
On 17 September 2013 20:50, Stephen Warren <swarren@wwwdotorg.org> wrote: > On 09/11/2013 11:25 PM, Viresh Kumar wrote: >> This broke after a recent change "cedb70a cpufreq: Split __cpufreq_remove_dev() >> into two parts" from Srivatsa.. >> >> Consider a scenario where we have two CPUs in a policy (0 & 1) and we are >> removing cpu 1. On the call to __cpufreq_remove_dev_prepare() we have cleared 1 >> from policy->cpus and now on a call to __cpufreq_remove_dev_finish() we read >> cpumask_weight of policy->cpus, which will come as 1 and this code will behave >> as if we are removing the last cpu from policy :) >> >> Fix it by clearing cpu mask in __cpufreq_remove_dev_finish() instead of >> __cpufreq_remove_dev_prepare(). > > I see this patch isn't in linux-next yet, nor did it make 3.12-rc1. I > assume it'll make 3.12-rc2? It solves various CPU hotplug and > suspend/resume issues for me.
Yes, I have asked Rafael to get this in for rc2 and few others too.. Waiting for his reply though..
-- viresh
| |