Messages in this thread | | | Date | Mon, 16 Sep 2013 12:06:14 +0100 | From | Lee Jones <> | Subject | Re: [PATCH 1/4 v2] mfd: add STw481x driver |
| |
On Mon, 16 Sep 2013, Mark Brown wrote:
> On Mon, Sep 16, 2013 at 10:19:56AM +0100, Lee Jones wrote: > > > Can't you just NULL .id_table? > > > Here's the code which would use it: > > > /* match on an id table if there is one */ > > > if (driver->id_table) > > > return i2c_match_id(driver->id_table, client) != NULL; > > > Matching for "dummy" will just waste cycles. > > i2c_device_probe() will return -ENODEV if id_table is NULL before we get > to actually matching. We could remove that check though...
Unless there will be any repercussions that I am naive to I think that sounds suitable. Any volunteers?
-- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |