Messages in this thread | | | Date | Sun, 15 Sep 2013 19:15:49 +0200 | From | Oleg Nesterov <> | Subject | Re: [PATCH] kmod: Check for NULL at call_usermodehelper_exec(). |
| |
On 09/16, Tetsuo Handa wrote: > > Oleg Nesterov wrote: > > It looks a bit ugly to check ->path under helper_lock(), just add > > > > if (!sub_info->path) > > retval = -ENOENT; > > > > at the start. Otherwise the code looks as if there is a subtle > > reason to take the lock before this check. > > Did you mean this? > > DECLARE_COMPLETION_ONSTACK(done); > int retval = 0; > > + if (!sub_info->path) { > + call_usermodehelper_freeinfo(sub_info);
Aah, sorry! I forgot about _freeinfo().
I still think that perhaps it makes sense to update the changelog, but this is minor.
Acked-by: Oleg Nesterov <oleg@redhat.com>
| |