lkml.org 
[lkml]   [2013]   [Sep]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 012/228] cpufreq: sparc: call cpufreq_frequency_table_get_attr()
    From
    On 14 September 2013 03:17, David Miller <davem@davemloft.net> wrote:
    > From: Viresh Kumar <viresh.kumar@linaro.org>
    > Date: Fri, 13 Sep 2013 18:29:18 +0530
    >
    >> This exposes frequency table of driver to cpufreq core and is required for core
    >> to guess what the index for a target frequency is, when it calls
    >> cpufreq_frequency_table_target(). And so this driver needs to expose it.
    >>
    >> Cc: David S. Miller <davem@davemloft.net>
    >> Cc: sparclinux@vger.kernel.org
    >> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
    >
    > Wait a second, later in this series you add the put_attr() call claiming
    > it's a fix.
    >
    > But you're the one adding the "bug" here.
    >
    > So if you are going to add a get_attr() call you should be adding the
    > necessary put_attr() call in the same patch. Otherwise this patch
    > introduces a bug.

    Yeah, my mistake.. It was required to be added at both places for
    very few drivers and so made this mistake..

    I will merge both of those patches together..


    \
     
     \ /
      Last update: 2013-09-14 06:21    [W:4.152 / U:0.112 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site