Messages in this thread | | | Date | Fri, 13 Sep 2013 16:56:00 -0700 | Subject | Re: [PATCH] Input: gpio_keys - wakeup_trigger | From | Doug Anderson <> |
| |
Benson,
On Fri, Sep 13, 2013 at 2:52 PM, Benson Leung <bleung@chromium.org> wrote: > Allow wakeup_trigger to be defined per gpio button. Currently, all > gpio buttons are set up as IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING. > It may be more appropriate to only wake the system on one edge, for example > if the gpio is for a Lid Switch. > > Signed-off-by: Benson Leung <bleung@chromium.org>
As discussed out of band, I'd tend to put the masking/error checking in gpio_keys_get_devtree_pdata() then just rely on non-DT users not to pass in nonsense, but I don't feel that strongly about it, so:
Reviewed-by: Doug Anderson <dianders@chromium.org>
| |