Messages in this thread | | | Subject | Re: [PATCH 1/1] isdn: hfcpci_softirq: get func return to suppress compiler warning | From | Ben Hutchings <> | Date | Fri, 13 Sep 2013 22:07:40 +0100 |
| |
On Fri, 2013-09-13 at 14:44 -0300, Antonio Alecrim Jr wrote: > Signed-off-by: Antonio Alecrim Jr <antonio.alecrim@gmail.com> > --- > drivers/isdn/hardware/mISDN/hfcpci.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/isdn/hardware/mISDN/hfcpci.c b/drivers/isdn/hardware/mISDN/hfcpci.c > index 7f910c7..5b8df75b 100644 > --- a/drivers/isdn/hardware/mISDN/hfcpci.c > +++ b/drivers/isdn/hardware/mISDN/hfcpci.c > @@ -2295,7 +2295,9 @@ _hfcpci_softirq(struct device *dev, void *arg) > static void > hfcpci_softirq(void *arg) > { > - (void) driver_for_each_device(&hfc_driver.driver, NULL, arg, > + int ret; > + > + ret = driver_for_each_device(&hfc_driver.driver, NULL, arg, > _hfcpci_softirq); > > /* if next event would be in the past ... */
This can result in a new compiler warning because ret is not used after it is assigned. Maybe add WARN_ON(ret)?
Ben.
-- Ben Hutchings, Staff Engineer, Solarflare Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked.
| |