Messages in this thread | | | Date | Fri, 13 Sep 2013 16:31:38 -0400 | Subject | Re: linux-next: manual merge of the akpm tree with Linus' tree | From | Linus Torvalds <> |
| |
On Fri, Sep 13, 2013 at 4:25 PM, Linus Torvalds <torvalds@linux-foundation.org> wrote: > > Yes. And I found the opposite bug in one place: when we are collecting > dentries by walking the parents etc, we do *not* hold the global RCU > lock, so we cannot use the "d_lru_shrink_list()" thing after all. It's > correct as far as the internal logic of fs/dcache.c goes, but it > violates the global LRU list rules. So I replaced that with a > dentry_lru_del() followed by a d_shrink_add() instead.
Actually, I replaced it with d_lru_del()+d_shrink_add(), because afaik we should be guaranteed that the dentry in question is on the global RCU list (we checked that refcount is 0, and it's not on a local list).
Agreed?
The patch I sent out already had that version, I just "documented" my first one.
Linus
| |