lkml.org 
[lkml]   [2013]   [Sep]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] gpio / ACPI: add support for GPIO operation regions
On Fri, Sep 13, 2013 at 06:55:11PM +0300, Andy Shevchenko wrote:
> On Fri, Sep 13, 2013 at 6:14 PM, Mika Westerberg
> <mika.westerberg@linux.intel.com> wrote:
> > GPIO operation regions is a new feature introduced in ACPI 5.0
> > specification. In practise it means that now ASL code can toggle GPIOs with
> > the help of the OS GPIO driver.
>
> []
>
> > void acpi_gpiochip_add(struct gpio_chip *chip)
> > {
> > + struct acpi_gpio_chip_data *data;
> > + acpi_handle handle;
> > + acpi_status status;
> > +
> > + handle = ACPI_HANDLE(chip->dev);
> > + if (!handle)
> > + return;
> > +
> > + data = kzalloc(sizeof(*data), GFP_KERNEL);
>
> May we use devm_kzalloc here?

The ACPI event handling code still uses kzalloc() and we need to call
acpi_gpiolib_remove() anyway (which undoes this), so I think we should
stick with kzalloc() now.


\
 
 \ /
  Last update: 2013-09-13 19:41    [W:0.172 / U:1.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site