lkml.org 
[lkml]   [2013]   [Sep]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[ 26/46] sfc: Fix lookup of default RX MAC filters when steered using ethtool
    Date
    3.10-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Ben Hutchings <bhutchings@solarflare.com>

    [ Upstream commit f3851b0acc5a75bd33c6d344a2e4f920e1622ff0 ]

    commit 385904f819e3 ('sfc: Don't use
    efx_filter_{build,hash,increment}() for default MAC filters') used the
    wrong name to find the index of default RX MAC filters at insertion/
    update time. This could result in memory corruption and would in any
    case silently fail to update the filter.

    Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/net/ethernet/sfc/filter.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/net/ethernet/sfc/filter.c
    +++ b/drivers/net/ethernet/sfc/filter.c
    @@ -675,7 +675,7 @@ s32 efx_filter_insert_filter(struct efx_
    BUILD_BUG_ON(EFX_FILTER_INDEX_UC_DEF != 0);
    BUILD_BUG_ON(EFX_FILTER_INDEX_MC_DEF !=
    EFX_FILTER_MC_DEF - EFX_FILTER_UC_DEF);
    - rep_index = spec->type - EFX_FILTER_INDEX_UC_DEF;
    + rep_index = spec->type - EFX_FILTER_UC_DEF;
    ins_index = rep_index;

    spin_lock_bh(&state->lock);



    \
     
     \ /
      Last update: 2013-09-13 00:21    [W:2.858 / U:0.132 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site