Messages in this thread | | | Date | Thu, 12 Sep 2013 23:35:32 +0200 (CEST) | From | Thomas Gleixner <> | Subject | Re: [RFC PATCH 1/4] DRIVERS: IRQCHIP: Add crossbar irqchip driver |
| |
On Thu, 12 Sep 2013, Felipe Balbi wrote:
> On Thu, Sep 12, 2013 at 09:09:08PM +0530, Sricharan R wrote: > > +unsigned int crossbar_request_irq(struct irq_data *d) > > +{ > > + int cb_no = d->hwirq; > > + int virq = allocate_free_irq(cb_no); > > + void *irq = &cb->crossbar_map[cb_no].hwirq; > > + int err; > > + > > + err = request_threaded_irq(virq, crossbar_irq, NULL, > > + 0, "CROSSBAR", irq); > > this is wrong, why don't you just set crossbar up as a chained handler.
That's just a detail, which does not solve the underlying problem of the crossbar -> GIC mapping.
Thanks,
tglx
| |