lkml.org 
[lkml]   [2013]   [Sep]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[218/251] zd1201: do not use stack as URB transfer_buffer
    3.6.11.9-rc1 stable review patch.
    If anyone has any objections, please let me know.

    ------------------

    From: Jussi Kivilinna <jussi.kivilinna@iki.fi>

    [ Upstream commit 1206ff4ff9d2ef7468a355328bc58ac6ebf5be44 ]

    Patch fixes zd1201 not to use stack as URB transfer_buffer. URB buffers need
    to be DMA-able, which stack is not.

    Patch is only compile tested.

    Cc: stable@vger.kernel.org
    Signed-off-by: Jussi Kivilinna <jussi.kivilinna@iki.fi>
    Signed-off-by: John W. Linville <linville@tuxdriver.com>
    Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
    ---
    drivers/net/wireless/zd1201.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    diff --git a/drivers/net/wireless/zd1201.c b/drivers/net/wireless/zd1201.c
    index 48273dd..4312eca 100644
    --- a/drivers/net/wireless/zd1201.c
    +++ b/drivers/net/wireless/zd1201.c
    @@ -98,10 +98,12 @@ static int zd1201_fw_upload(struct usb_device *dev, int apfw)
    goto exit;

    err = usb_control_msg(dev, usb_rcvctrlpipe(dev, 0), 0x4,
    - USB_DIR_IN | 0x40, 0,0, &ret, sizeof(ret), ZD1201_FW_TIMEOUT);
    + USB_DIR_IN | 0x40, 0, 0, buf, sizeof(ret), ZD1201_FW_TIMEOUT);
    if (err < 0)
    goto exit;

    + memcpy(&ret, buf, sizeof(ret));
    +
    if (ret & 0x80) {
    err = -EIO;
    goto exit;
    --
    1.7.10.4



    \
     
     \ /
      Last update: 2013-09-11 07:41    [W:4.099 / U:0.204 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site