lkml.org 
[lkml]   [2013]   [Sep]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[001/251] powerpc/smp: Section mismatch from smp_release_cpus to __initdata spinning_secondaries
    3.6.11.9-rc1 stable review patch.
    If anyone has any objections, please let me know.

    ------------------

    From: Chen Gang <gang.chen@asianux.com>

    [ Upstream commit 8246aca7058f3f2c2ae503081777965cd8df7b90 ]

    the smp_release_cpus is a normal funciton and called in normal environments,
    but it calls the __initdata spinning_secondaries.
    need modify spinning_secondaries to match smp_release_cpus.

    the related warning:
    (the linker report boot_paca.33377, but it should be spinning_secondaries)

    -----------------------------------------------------------------------------

    WARNING: arch/powerpc/kernel/built-in.o(.text+0x23176): Section mismatch in reference from the function .smp_release_cpus() to the variable .init.data:boot_paca.33377
    The function .smp_release_cpus() references
    the variable __initdata boot_paca.33377.
    This is often because .smp_release_cpus lacks a __initdata
    annotation or the annotation of boot_paca.33377 is wrong.

    WARNING: arch/powerpc/kernel/built-in.o(.text+0x231fe): Section mismatch in reference from the function .smp_release_cpus() to the variable .init.data:boot_paca.33377
    The function .smp_release_cpus() references
    the variable __initdata boot_paca.33377.
    This is often because .smp_release_cpus lacks a __initdata
    annotation or the annotation of boot_paca.33377 is wrong.

    -----------------------------------------------------------------------------

    Signed-off-by: Chen Gang <gang.chen@asianux.com>
    CC: <stable@vger.kernel.org>
    Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
    Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
    ---
    arch/powerpc/kernel/setup_64.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/arch/powerpc/kernel/setup_64.c b/arch/powerpc/kernel/setup_64.c
    index 389bd4f..5c9eccc 100644
    --- a/arch/powerpc/kernel/setup_64.c
    +++ b/arch/powerpc/kernel/setup_64.c
    @@ -76,7 +76,7 @@
    #endif

    int boot_cpuid = 0;
    -int __initdata spinning_secondaries;
    +int spinning_secondaries;
    u64 ppc64_pft_size;

    /* Pick defaults since we might want to patch instructions
    --
    1.7.10.4



    \
     
     \ /
      Last update: 2013-09-11 06:41    [W:4.106 / U:0.188 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site