Messages in this thread | | | Date | Tue, 10 Sep 2013 16:52:12 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH 3/6] tree-sweep: Include linux/sched.h for might_sleep users |
| |
On Sat, 31 Aug 2013 20:22:23 +0200 Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> On Fri, Aug 16, 2013 at 11:17 PM, Andi Kleen <andi@firstfloor.org> wrote: > > might_sleep is moving from linux/kernel.h to linux/sched.h, so any users > > need to include linux/sched.h > > Really? <linux/sched.h> is the worst choice w.r.t. include hell.
Yes. Mechanically adding sched.h inclusions into .h files will cause problems.
I've had decent success with this sort of thing by adding new, finer-grained headers. Maybe include/linux/might_sleep.h would be a good starting point to fix whatever it was that this fixed.
I think I'll make x86-include-linux-schedh-in-asm-uaccessh.patch, tree-sweep-include-linux-schedh-for-might_sleep-users.patch and sched-mark-should_resched-__always_inline.patch go away for now - I need a mergeable tree, fast.
| |