lkml.org 
[lkml]   [2013]   [Sep]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 7/7] sched, x86: Optimize the preempt_schedule() call

* Peter Zijlstra <peterz@infradead.org> wrote:

> + .macro SAVE_ALL
> + pushl_cfi %eax
> + CFI_REL_OFFSET eax, 0
> + pushl_cfi %ebp
> + CFI_REL_OFFSET ebp, 0
> + pushl_cfi %edi
> + CFI_REL_OFFSET edi, 0
> + pushl_cfi %esi
> + CFI_REL_OFFSET esi, 0
> + pushl_cfi %edx
> + CFI_REL_OFFSET edx, 0
> + pushl_cfi %ecx
> + CFI_REL_OFFSET ecx, 0
> + pushl_cfi %ebx
> + CFI_REL_OFFSET ebx, 0
> + .endm
> +
> + .macro RESTORE_ALL
> + popl_cfi %ebx
> + CFI_RESTORE ebx
> + popl_cfi %ecx
> + CFI_RESTORE ecx
> + popl_cfi %edx
> + CFI_RESTORE edx
> + popl_cfi %esi
> + CFI_RESTORE esi
> + popl_cfi %edi
> + CFI_RESTORE edi
> + popl_cfi %ebp
> + CFI_RESTORE ebp
> + popl_cfi %eax
> + CFI_RESTORE eax
> + .endm

Side note: shouldn't the pushl_cfi and popl_cfi macros be adjusted,
instead of open coding it?

Thanks,

Ingo


\
 
 \ /
  Last update: 2013-09-10 16:01    [W:0.217 / U:0.952 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site