lkml.org 
[lkml]   [2013]   [Sep]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] extcon: palmas: Dont set USB state if ID pin is grounded
    On 9/10/2013 2:47 PM, Laxman Dewangan wrote:
    > On Tuesday 10 September 2013 01:19 PM, George Cherian wrote:
    >> In OMAP5 when USB-HOST is set true, the VBUS regulator is turned ON.
    >> This causes a VBUS interrupt, ignore the same if we are already in
    >> USB-HOST.
    >>
    >> Signed-off-by: George Cherian <george.cherian@ti.com>
    >> ---
    >> drivers/extcon/extcon-palmas.c | 3 +++
    >> 1 file changed, 3 insertions(+)
    >>
    >> diff --git a/drivers/extcon/extcon-palmas.c
    >> b/drivers/extcon/extcon-palmas.c
    >> index 9672f31..91b31af 100644
    >> --- a/drivers/extcon/extcon-palmas.c
    >> +++ b/drivers/extcon/extcon-palmas.c
    >> @@ -50,6 +50,9 @@ static irqreturn_t palmas_vbus_irq_handler(int irq,
    >> void *_palmas_usb)
    >> struct palmas_usb *palmas_usb = _palmas_usb;
    >> unsigned int vbus_line_state;
    >> + if (palmas_usb->linkstat == PALMAS_USB_STATE_ID)
    >> + return IRQ_HANDLED;
    >> +
    >
    > Should we really handle this on this extcon driver? I think it should
    > be handled in the USB driver. If port is OTG type and if usb driver
    > enable the VBUS then it can expect the VBUS available notification but
    > based on the USB driver state, it should ignore this notification.
    >
    Correct extcon should just notify and the consumer should take
    appropriate decision.
    > Otherwise, Palmas pin find that there is VBUS state true but the SW
    > status will show as the VBUS not there.
    >


    --
    -George



    \
     
     \ /
      Last update: 2013-09-10 14:21    [W:4.712 / U:0.504 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site