lkml.org 
[lkml]   [2013]   [Sep]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/3] perf callchain: Convert children list to rbtree

* Jiri Olsa <jolsa@redhat.com> wrote:

> On Tue, Sep 10, 2013 at 05:24:16PM +0900, Namhyung Kim wrote:
> > From: Namhyung Kim <namhyung.kim@lge.com>
> >
> > Current collapse stage has a scalability problem which can be
> > reproduced easily with parallel kernel build. This is because it
> > needs to traverse every children of callchain linearly during the
> > collapse/merge stage. Convert it to rbtree reduced the overhead
> > significantly.
> >
> > On my 400MB perf.data file which recorded with make -j32 kernel build:
>
>
> nice!!!

Nice indeed!

> tried on 2.6 GB data file from kernel make -j64 and got report speed up
> from 'never' to 2m52.756s ;-)

It's still rather long though, unacceptable for everyday usage :-/

Frederic thought that we could reduce minimize collapsing to begin with.

Frederic, could you outline that in more detail please?

Thanks,

Ingo


\
 
 \ /
  Last update: 2013-09-10 12:41    [W:0.170 / U:0.488 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site