lkml.org 
[lkml]   [2013]   [Sep]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 03/50] sched, numa: Comment fixlets
    Date
    From: Peter Zijlstra <peterz@infradead.org>

    Fix a 80 column violation and a PTE vs PMD reference.

    Signed-off-by: Peter Zijlstra <peterz@infradead.org>
    Signed-off-by: Mel Gorman <mgorman@suse.de>
    ---
    kernel/sched/fair.c | 8 ++++----
    mm/huge_memory.c | 2 +-
    2 files changed, 5 insertions(+), 5 deletions(-)

    diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
    index 0c085ac..227b070 100644
    --- a/kernel/sched/fair.c
    +++ b/kernel/sched/fair.c
    @@ -988,10 +988,10 @@ void task_numa_work(struct callback_head *work)

    out:
    /*
    - * It is possible to reach the end of the VMA list but the last few VMAs are
    - * not guaranteed to the vma_migratable. If they are not, we would find the
    - * !migratable VMA on the next scan but not reset the scanner to the start
    - * so check it now.
    + * It is possible to reach the end of the VMA list but the last few
    + * VMAs are not guaranteed to the vma_migratable. If they are not, we
    + * would find the !migratable VMA on the next scan but not reset the
    + * scanner to the start so check it now.
    */
    if (vma)
    mm->numa_scan_offset = start;
    diff --git a/mm/huge_memory.c b/mm/huge_memory.c
    index a92012a..860a368 100644
    --- a/mm/huge_memory.c
    +++ b/mm/huge_memory.c
    @@ -1317,7 +1317,7 @@ int do_huge_pmd_numa_page(struct mm_struct *mm, struct vm_area_struct *vma,
    spin_unlock(&mm->page_table_lock);
    lock_page(page);

    - /* Confirm the PTE did not while locked */
    + /* Confirm the PMD did not change while page_table_lock was released */
    spin_lock(&mm->page_table_lock);
    if (unlikely(!pmd_same(pmd, *pmdp))) {
    unlock_page(page);
    --
    1.8.1.4


    \
     
     \ /
      Last update: 2013-09-10 12:21    [W:4.060 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site