lkml.org 
[lkml]   [2013]   [Sep]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 1/2] cpufreq: don't allow governor limits to be changed when it is disabled
    Date
    __cpufreq_governor() returns with -EBUSY when governor is already stopped and we
    try to stop it again, but when it is stopped we must not allow calls to
    CPUFREQ_GOV_LIMITS event as well.

    This patch adds this check in __cpufreq_governor().

    Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
    ---
    Hi Rafael,

    Its better if we can get these in for 3.11, otherwise we need to get them in the
    stable tree..

    Anyway, we will get these in 3.10 stable tree but that requires us to identify
    few more patches that will go with these. I will do that later.

    This must fix the issues reported by Stephen.

    Tested on my thinkpad over your linux-next branch.

    drivers/cpufreq/cpufreq.c | 5 +++--
    1 file changed, 3 insertions(+), 2 deletions(-)

    diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
    index 5c75e31..f320a20 100644
    --- a/drivers/cpufreq/cpufreq.c
    +++ b/drivers/cpufreq/cpufreq.c
    @@ -1692,8 +1692,9 @@ static int __cpufreq_governor(struct cpufreq_policy *policy,
    policy->cpu, event);

    mutex_lock(&cpufreq_governor_lock);
    - if ((!policy->governor_enabled && (event == CPUFREQ_GOV_STOP)) ||
    - (policy->governor_enabled && (event == CPUFREQ_GOV_START))) {
    + if ((policy->governor_enabled && (event == CPUFREQ_GOV_START)) ||
    + (!policy->governor_enabled && ((event == CPUFREQ_GOV_LIMITS) ||
    + (event == CPUFREQ_GOV_STOP)))) {
    mutex_unlock(&cpufreq_governor_lock);
    return -EBUSY;
    }
    --
    1.7.12.rc2.18.g61b472e


    \
     
     \ /
      Last update: 2013-09-01 07:41    [W:2.877 / U:0.320 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site