Messages in this thread | | | From | Namhyung Kim <> | Subject | Re: [PATCH 03/13] tracing/kprobes: Make stack and memory fetch functions static | Date | Fri, 09 Aug 2013 16:35:07 +0900 |
| |
Hi Masami-san,
On Mon, 05 Aug 2013 18:04:09 +0900, Masami Hiramatsu wrote: > (2013/07/31 18:03), Namhyung Kim wrote: >> From: Namhyung Kim <namhyung.kim@lge.com> >> >> Those fetch functions need to be implemented differently for kprobes >> and uprobes. Since the symbol and deref fetch functions don't call >> those directly anymore, we can make them static and implement them >> separately. > > Hmm, I think this should be done in 1/13, since this is partially > reverted it in the same series. If you concern about tweaking other > one's patch, you can add you singed-off-by to it. :)
The problem is that it should be marked static after converting to ->fetch() member. Otherwise the symbol and deref fetch method won't see memory fetch functions like:
/home/namhyung/project/linux/kernel/trace/trace_probe.c: In function ‘fetch_deref_u8’: /home/namhyung/project/linux/kernel/trace/trace_probe.c:115:1: error: implicit declaration of function ‘fetch_memory_u8’ [-Werror=implicit-function-declaration] /home/namhyung/project/linux/kernel/trace/trace_probe.c: In function ‘fetch_deref_u16’: /home/namhyung/project/linux/kernel/trace/trace_probe.c:115:1: error: implicit declaration of function ‘fetch_memory_u16’ [-Werror=implicit-function-declaration] /home/namhyung/project/linux/kernel/trace/trace_probe.c: In function ‘fetch_deref_u32’: /home/namhyung/project/linux/kernel/trace/trace_probe.c:115:1: error: implicit declaration of function ‘fetch_memory_u32’ [-Werror=implicit-function-declaration] /home/namhyung/project/linux/kernel/trace/trace_probe.c: In function ‘fetch_deref_u64’: /home/namhyung/project/linux/kernel/trace/trace_probe.c:115:1: error: implicit declaration of function ‘fetch_memory_u64’ [-Werror=implicit-function-declaration] /home/namhyung/project/linux/kernel/trace/trace_probe.c: In function ‘fetch_deref_string’: /home/namhyung/project/linux/kernel/trace/trace_probe.c:116:1: error: implicit declaration of function ‘fetch_memory_string’ [-Werror=implicit-function-declaration] /home/namhyung/project/linux/kernel/trace/trace_probe.c: In function ‘fetch_deref_string_size’: /home/namhyung/project/linux/kernel/trace/trace_probe.c:117:1: error: implicit declaration of function ‘fetch_memory_string_size’ [-Werror=implicit-function-declaration] cc1: some warnings being treated as errors
Thanks, Namhyung -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |