Messages in this thread | | | From | Namhyung Kim <> | Subject | Re: [PATCH V9 05/14] perf tools: tidy up sample parsing overflow checking | Date | Wed, 07 Aug 2013 17:54:08 +0900 |
| |
On Wed, 07 Aug 2013 11:19:32 +0300, Adrian Hunter wrote: > On 07/08/13 11:09, Namhyung Kim wrote: >> On Mon, 5 Aug 2013 19:26:25 +0300, Adrian Hunter wrote: >>> The size of data retrieved from a sample event must be >>> validated to ensure it does not go past the end of the >>> event. That was being done sporadically and without >>> considering integer overflows. >> >> Wouldn't it be great if the macro (or something) can do all three things >> together - checking overflow, getting current value (pointer) and >> advancing the array to the size? Is that possible? > > Macros are not the answer to everything.
Right.
But I was seeing repeating patterns of the three.. so I asked if there's a better alternative.
Thanks, Namhyung
| |