Messages in this thread | | | Date | Tue, 6 Aug 2013 08:48:15 +0200 | From | Daniel Wagner <> | Subject | Re: [PATCH 12/23] cgroup: pass around cgroup_subsys_state instead of cgroup in file methods |
| |
Hi Tejun,
On 08/01/2013 11:49 PM, Tejun Heo wrote: > cgroup is currently in the process of transitioning to using struct > cgroup_subsys_state * as the primary handle instead of struct cgroup. > Please see the previous commit which converts the subsystem methods > for rationale. > > This patch converts all cftype file operations to take @css instead of > @cgroup. cftypes for the cgroup core files don't have their subsytem > pointer set. These will automatically use the dummy_css added by the > previous patch and can be converted the same way. > > Most subsystem conversions are straight forwards but there are some > interesting ones. > > * freezer: update_if_frozen() is also converted to take @css instead > of @cgroup for consistency. This will make the code look simpler > too once iterators are converted to use css. > > * memory/vmpressure: mem_cgroup_from_css() needs to be exported to > vmpressure while mem_cgroup_from_cont() can be made static. > Updated accordingly. > > * cpu: cgroup_tg() doesn't have any user left. Removed. > > * cpuacct: cgroup_ca() doesn't have any user left. Removed. > > * hugetlb: hugetlb_cgroup_form_cgroup() doesn't have any user left. > Removed. > > * net_cls: cgrp_cls_state() doesn't have any user left. Removed. > > Signed-off-by: Tejun Heo <tj@kernel.org> > Cc: Li Zefan <lizefan@huawei.com> > Cc: Peter Zijlstra <peterz@infradead.org> > Cc: Ingo Molnar <mingo@redhat.com> > Cc: Johannes Weiner <hannes@cmpxchg.org> > Cc: Michal Hocko <mhocko@suse.cz> > Cc: Balbir Singh <bsingharora@gmail.com> > Cc: Aristeu Rozanski <aris@redhat.com> > Cc: Matt Helsley <matthltc@us.ibm.com> > Cc: Daniel Wagner <daniel.wagner@bmw-carit.de> > Cc: Vivek Goyal <vgoyal@redhat.com> > Cc: Jens Axboe <axboe@kernel.dk> > Cc: Steven Rostedt <rostedt@goodmis.org>
I guess I ended up because I did some changes on netprio_cgroup and cls_cgroup.
Acked-by: Daniel Wagner <daniel.wagner@bmw-carit.de>
cheers, daniel
| |