lkml.org 
[lkml]   [2013]   [Aug]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH v4 4/4] mmc: dw_mmc: Set timeout to max upon resume
    Date
    On Tuesday 06 of August 2013 14:37:51 Doug Anderson wrote:
    > The TMOUT register is initted to 0xffffffff at probe time but isn't
    > initted after suspend/resume. Add an init of this value.
    >
    > No problems were observed without this (it will also get initted in
    > __dw_mci_start_request if there is data to send), but it makes the
    > register dump before and after suspend clean.
    >
    > Signed-off-by: Doug Anderson <dianders@chromium.org>
    > Acked-by: Seungwon Jeon <tgih.jun@samsung.com>
    > ---
    > Changes in v4: None
    > Changes in v3: None
    > Changes in v2: None
    >
    > drivers/mmc/host/dw_mmc.c | 3 +++
    > 1 file changed, 3 insertions(+)
    >
    > diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
    > index 0fa3135..1abcb36 100644
    > --- a/drivers/mmc/host/dw_mmc.c
    > +++ b/drivers/mmc/host/dw_mmc.c
    > @@ -2505,6 +2505,9 @@ int dw_mci_resume(struct dw_mci *host)
    > /* Restore the old value at FIFOTH register */
    > mci_writel(host, FIFOTH, host->fifoth_val);
    >
    > + /* Put in max timeout */
    > + mci_writel(host, TMOUT, 0xFFFFFFFF);
    > +
    > mci_writel(host, RINTSTS, 0xFFFFFFFF);
    > mci_writel(host, INTMASK, SDMMC_INT_CMD_DONE | SDMMC_INT_DATA_OVER
    |
    > SDMMC_INT_TXDR | SDMMC_INT_RXDR |

    Not sure if we really care about register dumps, but if it gets
    initialized in probe as well, then this is fine.

    Reviewed-by: Tomasz Figa <t.figa@samsung.com>

    Best regards,
    Tomasz



    \
     
     \ /
      Last update: 2013-08-07 00:21    [W:5.878 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site