lkml.org 
[lkml]   [2013]   [Aug]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] perf tools: Renaming 'time' variable in perf_time_to_tsc due to name shadowing error
On Sat, Aug 03, 2013 at 10:23:05PM +0300, Adrian Hunter wrote:
> On 2/08/2013 4:33 p.m., Jiri Olsa wrote:
> >The perf compilation fails with following error:
> > ...
> > CC arch/x86/util/tsc.o
> > arch/x86/util/tsc.c: In function ‘perf_time_to_tsc’:
> > arch/x86/util/tsc.c:13:6: error: declaration of ‘time’ shadows a global declaration [-Werror=shadow]
> > cc1: all warnings being treated as errors
> >
> >Renaming the 'time' variable to prevent this.
>
> Did you see David did the same patch.
>
> Although David noted the gcc version. It doesn't happen for gcc
> 4.7.3. The commit message should probably reflect that it depends
> on the gcc version.

I haven't noticed Daivd's patch.. screw this one then

jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2013-08-05 10:21    [W:0.086 / U:0.328 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site