lkml.org 
[lkml]   [2013]   [Aug]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 02/15] cpufreq: cpufreq-cpu0: initialize .owner field with THIS_MODULE
    On Wed, Jul 31, 2013 at 07:49:11PM +0530, Viresh Kumar wrote:
    > CPUFreq core does following at multiple places:
    > module_{get|put}(cpufreq_driver->owner)).
    >
    > This is done to make sure module doesn't get unloaded if it is currently in use.
    > This will work only if the .owner field of cpufreq driver is initialized with a
    > valid pointer.
    >
    > This field wasn't initialized for this driver, lets initialize it with
    > THIS_MODULE.
    >
    > Cc: Shawn Guo <shawn.guo@linaro.org>
    > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>

    For this and imx6q-cpufreq one,

    Acked-by: Shawn Guo <shawn.guo@linaro.org>

    > ---
    > drivers/cpufreq/cpufreq-cpu0.c | 1 +
    > 1 file changed, 1 insertion(+)
    >
    > diff --git a/drivers/cpufreq/cpufreq-cpu0.c b/drivers/cpufreq/cpufreq-cpu0.c
    > index ad1fde2..a087bf1 100644
    > --- a/drivers/cpufreq/cpufreq-cpu0.c
    > +++ b/drivers/cpufreq/cpufreq-cpu0.c
    > @@ -169,6 +169,7 @@ static struct cpufreq_driver cpu0_cpufreq_driver = {
    > .init = cpu0_cpufreq_init,
    > .exit = cpu0_cpufreq_exit,
    > .name = "generic_cpu0",
    > + .owner = THIS_MODULE,
    > .attr = cpu0_cpufreq_attr,
    > };
    >
    > --
    > 1.7.12.rc2.18.g61b472e
    >



    \
     
     \ /
      Last update: 2013-08-04 14:01    [W:2.729 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site