Messages in this thread | | | Date | Fri, 30 Aug 2013 10:40:51 +0200 | Subject | Re: [PATCH 1/3 v3] pinctrl: ADI PIN control driver for the GPIO controller on bf54x and bf60x. | From | Linus Walleij <> |
| |
On Thu, Aug 29, 2013 at 11:31 AM, Sonic Zhang <sonic.adi@gmail.com> wrote: > On Thu, Aug 29, 2013 at 4:12 PM, Linus Walleij <linus.walleij@linaro.org> wrote:
>> This is similar to the situation in the pinctrl-nomadik.c driver, >> where the pinctrl portions wait for the GPIO devices to instantiate >> before proceeding to probe "on top" of the GPIO blocks, using >> the latter to get to the registers. >> >> I am not sure we have found the best way to sort out this >> type of system, let's see what we can come up with. > > In the blackfin pinctrol-adi2 driver, I probe all gpio devices > independently after all logic pinctrl devices. When one gpio device is > probed, it can get its pinctrl device name from its platform data and > add its gpio range into the pinctrl device via > gpiochip_add_pin_range(). The gpio device don't need to know anything > else about its pinctrl device.
This is ideal in the situation when there is a clear separation between the GPIO and pin control (muxing, biasing) registers. So you're doing the right thing.
Yours, Linus Walleij
| |