Messages in this thread | | | Date | Wed, 28 Aug 2013 18:40:38 +0400 | From | Sergei Shtylyov <> | Subject | Re: [PATCH v2 3/3] ARM: dts: dra7-evm: Add extcon nodes for USB ID pin detection |
| |
Hello.
On 08/28/2013 05:59 PM, George Cherian wrote:
> Add > -extcon nodes for USB ID pin detection. > -i2c nodes. > -pcf nodes to which USB ID pin is connected.
> Signed-off-by: George Cherian <george.cherian@ti.com> > --- > arch/arm/boot/dts/dra7-evm.dts | 52 +++++++++++++++++++++++++++++++++++++++++- > 1 file changed, 51 insertions(+), 1 deletion(-)
> diff --git a/arch/arm/boot/dts/dra7-evm.dts b/arch/arm/boot/dts/dra7-evm.dts > index acd3c09..9ee97c0 100644 > --- a/arch/arm/boot/dts/dra7-evm.dts > +++ b/arch/arm/boot/dts/dra7-evm.dts > @@ -17,6 +17,17 @@ > device_type = "memory"; > reg = <0x80000000 0x60000000>; /* 1536 MB */ > }; > + > + extcon1: gpio_usbvid_extcon1 { > + compatible = "ti,gpio-usb-id"; > + gpios = <&pcf_21 1 0>; > + }; > + > + extcon2: gpio_usbvid_extcon2 { > + compatible = "ti,gpio-usb-id"; > + gpios = <&pcf_21 2 0>; > + }; > + > }; > > &dra7_pmx_core { > @@ -33,10 +44,49 @@ > }; > }; > > +&i2c1 { > + clock-frequency = <400000>; > + > + pcf_20: pcf8575@20 {
Acorrding to the ePAPR spec [1], "the name of a node should be somewhat generic, reflecting the function of the device and not its precise programming model. If appropriate, the name should be one of the following choices:
[...] - gpio [...]"
> + compatible = "ti,pcf8575"; > + reg = <0x20>; > + n_latch = <0x4000>; > + gpio-controller; > + #gpio-cells = <2>; > + interrupt-parent = <&gpio6>; > + interrupts = <11 2>; > + interrupt-controller; > + #interrupt-cells = <2>; > + }; > + > + pcf_21: pcf8575@21 {
Same comment here.
> + compatible = "ti,pcf8575"; > + reg = <0x21>; > + n_latch = <0x1408>; > + gpio-controller; > + #gpio-cells = <2>; > + interrupt-parent = <&pcf_20>; > + interrupts = <14 2>; > + interrupt-controller; > + #interrupt-cells = <2>; > + }; > + > +}; > +
[1] http://www.power.org/resources/downloads/Power_ePAPR_APPROVED_v1.0.pdf
WBR, Sergei
| |