Messages in this thread | | | Date | Mon, 26 Aug 2013 10:53:54 -0600 | From | Stephen Warren <> | Subject | Re: [RFC PATCH 2/3] pinctrl: at91: add support for generic pinconf |
| |
On 08/24/2013 03:37 PM, Boris BREZILLON wrote: > Add support for generic pin configuration to pinctrl-at91 driver.
> diff --git a/Documentation/devicetree/bindings/pinctrl/atmel,at91-pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/atmel,at91-pinctrl.txt
> Required properties for iomux controller: > -- compatible: "atmel,at91rm9200-pinctrl" > +- compatible: "atmel,at91rm9200-pinctrl" or "atmel,at91sam9x5-pinctrl".
You seem to also be adding a second chip name to the list here, which is more than the patch subject/description imply you're doing...
> + Add "generic-pinconf" to the compatible string list to use the generic pin > + configuration syntax.
"generic-pinconf" is too generic of a compatible value for this binding to define.
Instead, I think you want to either:
a)
Use compatible="atmel,at91rm9200-pinctrl" for the old binding, use compatible="atmel,at91rm9200-pinctrl-generic" for the new binding
or:
b)
Define Boolean property atmel,generic-pinconf (perhaps a better name could be chosen?). If it's not present, parse the node assuming the old binding. If it is present, parse the node assuming the new binding.
| |